bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second time

[Kris Kennaway]

The following reply was made to PR bin/126324; it has been noted by GNATS.

From: Kris Kennaway <kris at FreeBSD.org>
To: Kris Kennaway <kris at FreeBSD.org>
Cc: Alex Kozlov <spam at rm-rf.kiev.ua>, freebsd-gnats-submit at FreeBSD.org
Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
 time
Date: Thu, 07 Aug 2008 12:35:43 +0200

 Kris Kennaway wrote:
 > Alex Kozlov wrote:
 > 
 >> Index: src/etc/rc.d/tmp
 >> @@ -43,6 +43,7 @@
 >>  #
 >>  case "${tmpmfs}" in
 >>  [Yy][Ee][Ss])
 >> +    /sbin/umount /tmp 2>/dev/null && echo /tmp was already mounted!
 >>      mount_md ${tmpsize} /tmp "${tmpmfs_flags}"
 >>      chmod 01777 /tmp
 >>      ;;
 >> @@ -57,6 +58,7 @@
 >>              echo "dropping into shell, ^D to continue anyway."
 >>              /bin/sh
 >>          else
 >> +            /sbin/umount /tmp 2>/dev/null && echo /tmp was already 
 >> mounted!
 >>              mount_md ${tmpsize} /tmp "${tmpmfs_flags}"
 >>              chmod 01777 /tmp
 >>          fi
 > 
 > This will destroy any files the admin may have deliberately created on 
 > /tmp after dropping to single user mode.
 
 Er, coffee hadn't kicked in.  That will only happen with tmpfs which 
 isn't used yet.  Still, a better solution might keep that in mind to 
 avoid introducing a bug later.
 
 Kris