kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints

Eugene Grosbein eugen at grosbein.pp.ru
Mon Sep 24 10:00:14 PDT 2007


The following reply was made to PR kern/116536; it has been noted by GNATS.

From: Eugene Grosbein <eugen at grosbein.pp.ru>
To: bug-followup at freebsd.org
Cc: Bruce Evans <brde at optusnet.com.au>
Subject: Re: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints
Date: Tue, 25 Sep 2007 00:56:54 +0800

 On Sat, 22 Sep 2007, Bruce Evans wrote:
 
 > fd->flags has nothing to do with the device flags.  This copy of the device
 > flags gets clobbered later when fd->flags is used for more-dynamic flags.
 
 int has (at least) 32 bits, why not use them?
 It's possible to move values for user-settable flags 
 (that are broken anyway for now) so that they do not globber
 with more-dynamic flags. What's the point in calls to device_get_flags()
 all the way?
 
 Eugene Grosbein


More information about the freebsd-bugs mailing list