msdosfs not MPSAFE

Tz-Huan Huang tzhuan at csie.org
Sat Sep 1 07:00:13 PDT 2007


2007/8/31, Bruce Evans <brde at optusnet.com.au>:
> This is too late.  I just got approval to commit my version mailed
> here on 10 Aug, and will commit it today.  That version also removes
> the globals, but doesn't change the algorithm so much.  Your version
> seems to be simpler but has too many style bugs for me.  If you want
> to do more work on this, please adjust your patch to apply to the
> version that I will commit and clean it up.

(sorry that I forgot to replay to all in the previous mail)

Ok, the attachment is the new version.
I think it's worth committing because it doesn't only solve the global
variables problem but also solve the kiconv problem. In original
interface the win2unixchr() return a 2-byte int thus it's impossible to
convert from UTF-16BE to UTF-8 because the size of a character in
UTF-8 may be from 1 byte to 6 bytes.

Tz-Huan Huang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msdosfs.diff
Type: application/octet-stream
Size: 14549 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-bugs/attachments/20070901/9b272090/msdosfs.obj


More information about the freebsd-bugs mailing list