kern/116896: Typo in a kassert in GEOM

VANHULLEBUS Yvan vanhu at
Thu Oct 4 02:20:04 PDT 2007

>Number:         116896
>Category:       kern
>Synopsis:       Typo in a kassert in GEOM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 04 09:20:02 GMT 2007
>Originator:     VANHULLEBUS Yvan
>Release:        FreeBSD 6.2-STABLE i386
System: FreeBSD 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Jan 22 14:18:45 CET 2007 root at i386


I'm not sure if this could be a real problem, but there is a small typo
in a KASSERT: 
in geom/geom_subr.c, function g_destroy_provider(), pp->acw is checked twice
but pp->ace is not checked.


Index: geom/geom_subr.c
RCS file: /home/ncvs/src/sys/geom/geom_subr.c,v
retrieving revision 1.91
diff -b -u -p -r1.91 geom_subr.c
--- geom/geom_subr.c	5 May 2007 16:33:44 -0000	1.91
+++ geom/geom_subr.c	4 Oct 2007 09:14:13 -0000
@@ -554,7 +554,7 @@ g_destroy_provider(struct g_provider *pp
 	    ("g_destroy_provider but attached"));
 	KASSERT (pp->acr == 0, ("g_destroy_provider with acr"));
 	KASSERT (pp->acw == 0, ("g_destroy_provider with acw"));
-	KASSERT (pp->acw == 0, ("g_destroy_provider with ace"));
+	KASSERT (pp->ace == 0, ("g_destroy_provider with ace"));
 	LIST_REMOVE(pp, provider);
 	gp = pp->geom;


More information about the freebsd-bugs mailing list