kern/110720: [net] [patch] support for interface descriptions

Andre Oppermann andre at freebsd.org
Sat Mar 24 11:07:24 UTC 2007


Harti Brandt wrote:
> Nice feature, although it would be nice to align the maximum length with 
> IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more 
> naturally fits into struct if_data (see net/if.h) given the comment for 
> that struct:
> 
> /*
>  * Structure describing information about an interface
>  * which may be of interest to management entities.
>  */

The string array should most likely not be part of struct ifnet as that
would bloat it quite a bit.  If it is in there it should be at the end
of the struct to avoid cache line busting effects.

-- 
Andre



More information about the freebsd-bugs mailing list