bin/110178: [patch] Fix handling of -n option in /sbin/mdmfs

Alex Kozlov spam at
Sun Mar 11 04:50:05 UTC 2007

>Number:         110178
>Category:       bin
>Synopsis:       [patch] Fix handling of -n option in /sbin/mdmfs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 04:50:03 GMT 2007
>Originator:     Alex Kozlov
>Release:        FreeBSD 6.2
mdmfs describes -n option as 'rotational-positions' but in newfs it means 'do not create a .snap directory'


Patch attached with submission follows:

--- mdmfs.c
@@ -127,7 +127,7 @@
 	while ((ch = getopt(argc, argv,
-	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:Nn:O:o:Pp:Ss:t:Uv:w:X")) != -1)
+	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:NnO:o:Pp:Ss:t:Uv:w:X")) != -1)
 		switch (ch) {
 		case 'a':
 			argappend(&newfs_arg, "-a %s", optarg);
@@ -188,7 +188,7 @@
 			norun = true;
 		case 'n':
-			argappend(&newfs_arg, "-n %s", optarg);
+			argappend(&newfs_arg, "-n");
 		case 'O':
 			argappend(&newfs_arg, "-o %s", optarg);
@@ -655,10 +655,10 @@
-"usage: %s [-DLlMNPSUX] [-a maxcontig] [-b block-size]\n"
+"usage: %s [-DLlMNnPSUX] [-a maxcontig] [-b block-size]\n"
 "\t[-c blocks-per-cylinder-group][-d max-extent-size] [-E path-mdconfig]\n"
 "\t[-e maxbpg] [-F file] [-f frag-size] [-i bytes] [-m percent-free]\n"
-"\t[-n rotational-positions] [-O optimization] [-o mount-options]\n"
+"\t[-O optimization] [-o mount-options]\n"
 "\t[-p permissions] [-s size] [-v version] [-w user:group]\n"
 "\tmd-device mount-point\n", getprogname());


More information about the freebsd-bugs mailing list