misc/113979: sysinstall does not support UFS1 filesystems in install.cfg

[David Sanderson]

>Number:         113979
>Category:       misc
>Synopsis:       sysinstall does not support UFS1 filesystems in install.cfg
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 24 00:20:00 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     David Sanderson
>Release:        FreeBSD 6.2
>Organization:
Panasas, Inc.
>Environment:
FreeBSD perf-x4 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 08:43:30 UTC 2007     root at portnoy.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP  amd64
>Description:
The FreeBSD 6.2 sysinstall supports creating UFS1 or UFS2 filesystems when used interactively, but only supports UFS2 filesystems via a noninteractive install via install.cfg.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Change 210521 by dsanderson at dsanderson-k2-sb7-tango-bsd-dws2 on 2007/06/23 19:10:32

	Teach the FreeBSD 6 sysinstall how to create a UFS1 filesystem
	via install.cfg.
	
	The default is still UFS2.  To select UFS1, use "ufs1" as the
	filesystem type in the label arguments.
	
	Tested with an install.cfg fragment like so:
	
	    # root, 8 GB
	    twed0s1-1=ufs1 16777216 /
	    # swap, 8 GB
	    twed0s1-2=swap 16777216 none
	    # /var, rest of the disk
	    twed0s1-4=ufs1        0 /var
	    # now invoke the label editor
	    diskLabelEditor
	
	To see whether a filesystem is UFS1 or UFS2, you can use dumpfs.
	For instance,
	
	    11826358700000# dumpfs / | sed 1q
	    magic   11954 (UFS1)    time    Sat Jun 23 23:06:41 2007
	
Affected files ...

.. //depot/branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c#2 edit

Differences ...

==== //depot/branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c#2 (text) ====
Index: branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c
--- branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c.~1~	Sat Jun 23 20:05:33 2007
+++ branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c	Sat Jun 23 20:05:33 2007
@@ -1636,6 +1636,7 @@
 	    for (entries = 1;; entries++) {
 		intmax_t sz;
 		int soft = 0;
+		int ufs1 = 0;
 		snprintf(name, sizeof name, "%s-%d", c1->name, entries);
 		if ((cp = variable_get(name)) == NULL)
 		    break;
@@ -1652,6 +1653,8 @@
 			strcpy(mpoint, "SWAP");
 		    } else {
 			type = PART_FILESYSTEM;
+		        if (!strcmp(typ, "ufs1"))
+			    ufs1 = 1;
 			if (!strcmp(mpoint, "/"))
 			    flags |= CHUNK_IS_ROOT;
 		    }
@@ -1672,6 +1675,7 @@
 			pi = tmp->private_data = new_part(PART_FILESYSTEM, mpoint, TRUE);
 			tmp->private_free = safe_free;
 			pi->newfs_data.newfs_ufs.softupdates = soft;
+	                pi->newfs_data.newfs_ufs.ufs1 = ufs1;
 		    }
 		}
 	    }
End of Patch.


>Release-Note:
>Audit-Trail:
>Unformatted: