Subject: Re: bin/112827: [PATCH]: chmod-like -f & -v options to chflags(1)

[Ighighi Ighighi]

The following reply was made to PR bin/112827; it has been noted by GNATS.

From: "Ighighi Ighighi" <ighighi at gmail.com>
To: bug-followup at freebsd.org
Cc:  
Subject: Subject: Re: bin/112827: [PATCH]: chmod-like -f & -v options to chflags(1)
Date: Tue, 12 Jun 2007 05:37:29 -0400

 ------=_Part_2435_25810679.1181641049136
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 This new patch makes chflags(1) even more chmod/chown/chgrp -like by
 only reporting
 those files that really changed their flags with the -v option and
 allowing this option to be
 specified twice.
 
 This patch (meant to substitute the old one) was successfully tested on:
 FreeBSD 6.2-STABLE #0: Tue Jun 12 01:05:00 VET 2007
 root at orion:/usr/obj/usr/src/sys/CUSTOM  i386
 
 It patches ok on both 6-STABLE & -CURRENT as of time of writing.
 The respective RCS versions are:
 
      $FreeBSD: src/bin/chflags/chflags.1,v 1.25.2.1 2006/05/17
 13:20:21 trhodes Exp $
      $FreeBSD: src/bin/chflags/chflags.c,v 1.23 2005/05/14 23:23:10 dd Exp $
 
      $FreeBSD: src/bin/chflags/chflags.1,v 1.29 2007/05/28 04:23:09 pjd Exp $
      $FreeBSD: src/bin/chflags/chflags.c,v 1.23 2005/05/14 23:23:10 dd Exp $
 
 ------=_Part_2435_25810679.1181641049136
 Content-Type: text/plain; name=chflags-patch.txt; charset=ANSI_X3.4-1968
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_f2u5n2oz
 Content-Disposition: attachment; filename="chflags-patch.txt"
 
 LS0tIHNyYy9iaW4vY2hmbGFncy9jaGZsYWdzLmMub3JpZwlTYXQgTWF5IDE0IDE5OjIzOjEwIDIw
 MDUKKysrIHNyYy9iaW4vY2hmbGFncy9jaGZsYWdzLmMJVHVlIEp1biAxMiAwNDo0MToxNSAyMDA3
 CkBAIC02MiwxMiArNjIsMTMgQEAKIAlGVFNFTlQgKnA7CiAJdV9sb25nIGNsZWFyLCBzZXQ7CiAJ
 bG9uZyB2YWw7Ci0JaW50IEhmbGFnLCBMZmxhZywgUmZsYWcsIGhmbGFnLCBjaCwgZnRzX29wdGlv
 bnMsIG9jdCwgcnZhbDsKKwlpbnQgSGZsYWcsIExmbGFnLCBSZmxhZywgZmZsYWcsIGhmbGFnLCB2
 ZmxhZywgY2gsIGZ0c19vcHRpb25zLCBvY3QsIHJ2YWw7CiAJY2hhciAqZmxhZ3MsICplcDsKKwl1
 X2xvbmcgbmV3ZmxhZ3M7CiAJaW50ICgqY2hhbmdlX2ZsYWdzKShjb25zdCBjaGFyICosIHVuc2ln
 bmVkIGxvbmcpOwogCi0JSGZsYWcgPSBMZmxhZyA9IFJmbGFnID0gaGZsYWcgPSAwOwotCXdoaWxl
 ICgoY2ggPSBnZXRvcHQoYXJnYywgYXJndiwgIkhMUFJoIikpICE9IC0xKQorCUhmbGFnID0gTGZs
 YWcgPSBSZmxhZyA9IGZmbGFnID0gaGZsYWcgPSB2ZmxhZyA9IDA7CisJd2hpbGUgKChjaCA9IGdl
 dG9wdChhcmdjLCBhcmd2LCAiSExQUmZodiIpKSAhPSAtMSkKIAkJc3dpdGNoIChjaCkgewogCQlj
 YXNlICdIJzoKIAkJCUhmbGFnID0gMTsKQEAgLTgzLDkgKzg0LDE1IEBACiAJCWNhc2UgJ1InOgog
 CQkJUmZsYWcgPSAxOwogCQkJYnJlYWs7CisJCWNhc2UgJ2YnOgorCQkJZmZsYWcgPSAxOworCQkJ
 YnJlYWs7CiAJCWNhc2UgJ2gnOgogCQkJaGZsYWcgPSAxOwogCQkJYnJlYWs7CisJCWNhc2UgJ3Yn
 OgorCQkJdmZsYWcgPSAxOworCQkJYnJlYWs7CiAJCWNhc2UgJz8nOgogCQlkZWZhdWx0OgogCQkJ
 dXNhZ2UoKTsKQEAgLTE2NiwxOCArMTczLDIwIEBACiAJCWRlZmF1bHQ6CiAJCQlicmVhazsKIAkJ
 fQotCQlpZiAob2N0KSB7Ci0JCQlpZiAoISgqY2hhbmdlX2ZsYWdzKShwLT5mdHNfYWNjcGF0aCwg
 c2V0KSkKLQkJCQljb250aW51ZTsKLQkJfSBlbHNlIHsKLQkJCXAtPmZ0c19zdGF0cC0+c3RfZmxh
 Z3MgfD0gc2V0OwotCQkJcC0+ZnRzX3N0YXRwLT5zdF9mbGFncyAmPSBjbGVhcjsKLQkJCWlmICgh
 KCpjaGFuZ2VfZmxhZ3MpKHAtPmZ0c19hY2NwYXRoLAotCQkJCSAgICAodV9sb25nKXAtPmZ0c19z
 dGF0cC0+c3RfZmxhZ3MpKQotCQkJCWNvbnRpbnVlOworCQluZXdmbGFncyA9IG9jdCA/IHNldCA6
 IChwLT5mdHNfc3RhdHAtPnN0X2ZsYWdzIHwgc2V0KSAmIGNsZWFyOworCQlpZiAobmV3ZmxhZ3Mg
 PT0gcC0+ZnRzX3N0YXRwLT5zdF9mbGFncykKKwkJCWNvbnRpbnVlOworCQlpZiAoKCpjaGFuZ2Vf
 ZmxhZ3MpKHAtPmZ0c19hY2NwYXRoLCBuZXdmbGFncykgJiYgIWZmbGFnKSB7CisJCQl3YXJuKCIl
 cyIsIHAtPmZ0c19wYXRoKTsKKwkJCXJ2YWwgPSAxOworCQl9IGVsc2UgaWYgKHZmbGFnKSB7CisJ
 CQkodm9pZClwcmludGYoIiVzIiwgcC0+ZnRzX3BhdGgpOworCisJCQlpZiAodmZsYWcgPiAxKQor
 CQkJCSh2b2lkKXByaW50ZigiOiAwJWxvIC0+IDAlbG8iLAorCQkJCSAgICAodV9sb25nKSBwLT5m
 dHNfc3RhdHAtPnN0X2ZsYWdzLCBuZXdmbGFncyk7CisJCQkodm9pZClwcmludGYoIlxuIik7CiAJ
 CX0KLQkJd2FybigiJXMiLCBwLT5mdHNfcGF0aCk7Ci0JCXJ2YWwgPSAxOwogCX0KIAlpZiAoZXJy
 bm8pCiAJCWVycigxLCAiZnRzX3JlYWQiKTsKQEAgLTE4OCw2ICsxOTcsNiBAQAogdXNhZ2Uodm9p
 ZCkKIHsKIAkodm9pZClmcHJpbnRmKHN0ZGVyciwKLQkgICAgInVzYWdlOiBjaGZsYWdzIFstaF0g
 Wy1SIFstSCB8IC1MIHwgLVBdXSBmbGFncyBmaWxlIC4uLlxuIik7CisJICAgICJ1c2FnZTogY2hm
 bGFncyBbLWZodl0gWy1SIFstSCB8IC1MIHwgLVBdXSBmbGFncyBmaWxlIC4uLlxuIik7CiAJZXhp
 dCgxKTsKIH0KLS0tIHNyYy9iaW4vY2hmbGFncy9jaGZsYWdzLjEub3JpZwlXZWQgTWF5IDE3IDA5
 OjIwOjIxIDIwMDYKKysrIHNyYy9iaW4vY2hmbGFncy9jaGZsYWdzLjEJVHVlIEp1biAxMiAwNDo1
 NjoxOSAyMDA3CkBAIC00MCw3ICs0MCw3IEBACiAuTmQgY2hhbmdlIGZpbGUgZmxhZ3MKIC5TaCBT
 WU5PUFNJUwogLk5tCi0uT3AgRmwgaAorLk9wIEZsIGZodgogLk9vCiAuRmwgUgogLk9wIEZsIEgg
 fCBGbCBMIHwgRmwgUApAQCAtNTcsNiArNTcsMTIgQEAKIC5QcAogVGhlIG9wdGlvbnMgYXJlIGFz
 IGZvbGxvd3M6CiAuQmwgLXRhZyAtd2lkdGggaW5kZW50CisuSXQgRmwgZgorRG8gbm90IGRpc3Bs
 YXkgYSBkaWFnbm9zdGljIG1lc3NhZ2UgaWYKKy5ObQorY291bGQgbm90IG1vZGlmeSB0aGUgZmxh
 Z3MgZm9yCisuVmEgZmlsZSAsCitub3IgbW9kaWZ5IHRoZSBleGl0IHN0YXR1cyB0byByZWZsZWN0
 IHN1Y2ggZmFpbHVyZXMuCiAuSXQgRmwgSAogSWYgdGhlCiAuRmwgUgpAQCAtNzksNiArODUsMTQg
 QEAKIC5JdCBGbCBSCiBDaGFuZ2UgdGhlIGZpbGUgZmxhZ3MgZm9yIHRoZSBmaWxlIGhpZXJhcmNo
 aWVzIHJvb3RlZAogaW4gdGhlIGZpbGVzIGluc3RlYWQgb2YganVzdCB0aGUgZmlsZXMgdGhlbXNl
 bHZlcy4KKy5JdCBGbCB2CitDYXVzZQorLk5tCit0byBiZSB2ZXJib3NlLCBzaG93aW5nIGZpbGVu
 YW1lcyBhcyB0aGUgZmxhZ3MgYXJlIG1vZGlmaWVkLgorSWYgdGhlCisuRmwgdgorb3B0aW9uIGlz
 IHNwZWNpZmllZCBtb3JlIHRoYW4gb25jZSwgdGhlIG9sZCBhbmQgbmV3IGZsYWdzIG9mIHRoZSBm
 aWxlCit3aWxsIGFsc28gYmUgcHJpbnRlZCwgaW4gb2N0YWwgbm90YXRpb24uCiAuRWwKIC5QcAog
 VGhlIGZsYWdzIGFyZSBzcGVjaWZpZWQgYXMgYW4gb2N0YWwgbnVtYmVyIG9yIGEgY29tbWEgc2Vw
 YXJhdGVkIGxpc3QK
 ------=_Part_2435_25810679.1181641049136--