kern/114802: sys/pci/agp_i810.c misses i845G chipset

[Alex Goncharov]

>Number:         114802
>Category:       kern
>Synopsis:       sys/pci/agp_i810.c misses i845G chipset
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 22 03:20:02 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Alex Goncharov
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
N/A
>Environment:
System: FreeBSD fasolt 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat Jul 21 17:26:14 EDT 2007 root at MYHOST:/usr/obj/usr/src-7.0-CURRENT/sys/GENERIC i386

>Description:

After a code upgrade from 6.2-STABLE to 7.0-CURRENT, the X server
won't start, complaining about the absense of `/dev/agpgart', which is
missing indeed.

>How-To-Repeat:

* Have a machine with '82845G/GL/GV/GE/PE Integrated Graphics Device'.

* Install 7.0-CURRENT, where the revision's sys/pci/agp_i810.c CVS Id
  is:

  $FreeBSD: src/sys/pci/agp_i810.c,v 1.40 2007/07/13 16:28:12

  Reboot.

* Observe the lack of `/dev/agpgart'.

* Observe the failure to start X (provided the `xorg.conf' uses the
  i810 driver:

Section "Device"
        Driver      "i810"
EndSection

>Fix:

Applying the following patch:
===================================================================
--- sys/pci/agp_i810.c 2007-07-21 14:56:26.000000000 -0400
+++ sys/pci/agp_i810.c-fixed  2007-07-21 15:27:26.000000000 -0400
@@ -130,6 +130,8 @@
            "Intel 82815 (i815 GMCH) SVGA controller"},
        {0x35778086, CHIP_I830, 0x00020000,
            "Intel 82830M (830M GMCH) SVGA controller"},
+       {0x25628086, CHIP_I830, 0x00020000,
+           "Intel 82845M (845M GMCH) SVGA controller"},
        {0x35828086, CHIP_I855, 0x00020000,
            "Intel 82852/5"},
        {0x25728086, CHIP_I855, 0x00020000,
===================================================================

resolves the issue -- after a rebuild and restart, `/dev/agpgart' does
appear, and the X servers starts and operates problem-free.

Note that the quoted string, "Intel 82845M (845M GMCH) SVGA
controller", may need to be changed to give a more accurate
information on the controller.

After the fix, pcicong -lv produces (in the relevant piece):

===================================================================

vgapci0 at pci0:2:0:       class=0x030000 card=0x01271028 chip=0x25628086 rev=0x01 
hdr=0x00
    vendor     = 'Intel Corporation'
    device     = '82845G/GL/GV/GE/PE Integrated Graphics Device'
    class      = display
    subclass   = VGA
===================================================================
>Release-Note:
>Audit-Trail:
>Unformatted: