bin/115372: "ipfw show" prints ill result.

[Tsurutani Naoki]

>Number:         115372
>Category:       bin
>Synopsis:       "ipfw show" prints ill result.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 10 07:00:07 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Tsurutani Naoki
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD polymer3.scphys.kyoto-u.ac.jp 6.2-STABLE FreeBSD 6.2-STABLE #10: Thu Aug 9 09:51:27 JST 2007 turutani at polymer3.scphys.kyoto-u.ac.jp:/usr/local/work/usr/obj/usr/src/sys/POLYMER i386


	
>Description:
	running "ipfw show" prints ill result when a rule like
		${fwcmd} add 1 allow layer2 not mac-type ip
	is set.
	output is
		00001  0  0 allow ip from any to any layer2 not not mac-type 0x0800
	Two "not" present.
	
>How-To-Repeat:
	add abobe rule in /etc/rc.firewall, run it, and the run "ipfw show".
	rules containing "mac-type" causes this.
	
>Fix:
	This is introduced by rev.1.76.2.19 of src/sbin/ipfw/ipfw2.c.
	The older version does not produce this problem, as I checked.
	The structure of switch statement in show_ipfw() are changed
	at this revision, and "O_MACADDR2" is moved into deeper switch condition
	of the default condition of more global switch().
	The first "not" is by "default" section, and the 2nd is
	by print_newports().
	I do not know how to fix correctly.
	


>Release-Note:
>Audit-Trail:
>Unformatted: