kern/112119: system hangs when starts k3b on RELENG_6

Mon Apr 30 02:00:19 UTC 2007

The following reply was made to PR kern/112119; it has been noted by GNATS.

From: Ganbold <ganbold at micom.mng.net>
To: Thomas Quinot <thomas at FreeBSD.ORG>
Cc: Scott Long <scottl at samsco.org>, Nikolay Pavlov <quetzal at zone3000.net>, 
 freebsd-stable at FreeBSD.ORG,  mjacob at FreeBSD.ORG,  linimon at FreeBSD.ORG, 
 bug-followup at FreeBSD.ORG
Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6
Date: Mon, 30 Apr 2007 09:50:48 +0800

 This is a multi-part message in MIME format.
 --------------080102070607070608080708
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit

 Thomas Quinot wrote:
 > * Scott Long, 2007-04-27 :
 >
 >   
 >> Oh hell, I know exactly what the problem is!  The opcode for a
 >> TEST_UNIT_READY is 0x00.  This is probably the command that is
 >> generating the CHECK_CONDITION.  The test for saved_cmd is entirely
 >> bogus.
 >>     
 >
 > Hmmmm. Looks like a very plausible culprit. Good catch Scott!
 > (I felt there had to be something wrong when I wrote that test,
 > incidentally, precisely because of TEST_UNIT_READY).
 >
 > Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3,
 > please let me know if it works for you.
 >
 > Thomas.
 >
 > Index: atapi-cam.c
 > ===================================================================
 > RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v
 > retrieving revision 1.50
 > diff -u -r1.50 atapi-cam.c
 > --- atapi-cam.c	14 Mar 2007 01:59:00 -0000	1.50
 > +++ atapi-cam.c	27 Apr 2007 19:26:09 -0000
 > @@ -729,7 +743,7 @@
 >  		 * issued a REQUEST SENSE automatically and that operation
 >  		 * returned without error.
 >  		 */
 > -		if (request->u.atapi.saved_cmd != 0 && request->error == 0) {
 > +		if (request->u.atapi.sense.key != 0 && request->error == 0) {
 >  		    bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense));
 >  		    csio->ccb_h.status |= CAM_AUTOSNS_VALID;
 >  		}
 >
 >
 >
 >   

 Scott, Thomas, thank you very much for the effort fixing this problem.
 k3b starts fine with this patch.

 Ganbold

 --------------080102070607070608080708
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit

 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
 <head>
   <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
 </head>
 <body bgcolor="#ffffff" text="#000000">
 Thomas Quinot wrote:
 <blockquote cite="mid:20070427193119.GA95165 at melamine.cuivre.fr.eu.org"
  type="cite">
   <pre wrap="">* Scott Long, 2007-04-27 :

   </pre>
   <blockquote type="cite">
     <pre wrap="">Oh hell, I know exactly what the problem is!  The opcode for a
 TEST_UNIT_READY is 0x00.  This is probably the command that is
 generating the CHECK_CONDITION.  The test for saved_cmd is entirely
 bogus.
     </pre>
   </blockquote>
   <pre wrap=""><!---->
 Hmmmm. Looks like a very plausible culprit. Good catch Scott!
 (I felt there had to be something wrong when I wrote that test,
 incidentally, precisely because of TEST_UNIT_READY).

 Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3,
 please let me know if it works for you.

 Thomas.

 Index: atapi-cam.c
 ===================================================================
 RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v
 retrieving revision 1.50
 diff -u -r1.50 atapi-cam.c
 --- atapi-cam.c	14 Mar 2007 01:59:00 -0000	1.50
 +++ atapi-cam.c	27 Apr 2007 19:26:09 -0000
 @@ -729,7 +743,7 @@
  		 * issued a REQUEST SENSE automatically and that operation
  		 * returned without error.
  		 */
 -		if (request-&gt;u.atapi.saved_cmd != 0 &amp;&amp; request-&gt;error == 0) {
 +		if (request-&gt;u.atapi.sense.key != 0 &amp;&amp; request-&gt;error == 0) {
  		    bcopy (&amp;request-&gt;u.atapi.sense, &amp;csio-&gt;sense_data, sizeof(struct atapi_sense));
  		    csio-&gt;ccb_h.status |= CAM_AUTOSNS_VALID;
  		}

</pre>
 </blockquote>
 
 Scott, Thomas, thank you very much for the effort fixing this problem. 
 k3b starts fine with this patch. 
 
 Ganbold 
 
 
 </body>
 </html>

 --------------080102070607070608080708--