kern/71792: [vm] [patch] Wrong/missing 'goto' target label in contigmalloc1()

[Gavin Atkinson]

The following reply was made to PR kern/71792; it has been noted by GNATS.

From: Gavin Atkinson <gavin.atkinson at ury.york.ac.uk>
To: bug-followup at FreeBSD.org, gemini at geminix.org
Cc:  
Subject: Re: kern/71792: [vm] [patch] Wrong/missing 'goto' target label in
	contigmalloc1()
Date: Thu, 26 Apr 2007 11:54:38 +0100

 I have no idea if this is actually a bug or not, but note that the code
 has changed significantly since this PR was submitted.  In -HEAD, the
 function in question is in src/sys/vm/vm_contig.c
 
 In revision 1.10, the copied/pasted code was factored out, but retained
 the same "goto" semantics that the submitter believes are wrong:
 http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/vm/vm_contig.c.diff?r1=1.9;r2=1.10
 
 Since then, the code has carried on morphing, and the goto in question
 is around line 234 of -HEAD, and is still effectively the same as it
 always was.
 
 This probably needs looking at by a VM expert (alc?) to determine if the
 original submitter's issues with the code are valid.  I do note that
 DragonFlyBVSD seem to have changed this code in
 http://www.dragonflybsd.org/cvsweb/src/sys/vm/vm_contig.c.diff?r1=1.12&r2=1.13 with a commit message indicating that it did indeed fix a possible endless loop.