kern/85493: OLDCARD can't probe ed driver

[M. Warner Losh]

In message: <20060921.010358.39312857.keiji at hiemalis.org>
            Wada Keiji <keiji at hiemalis.org> writes:
: Hello imp!
: 
: Why don't you accept my change request?
: 
: Did you read sys/dev/pccard/card_if.m
: # Compatibility methods for OLDCARD drivers.  We use these routines to make
: # it possible to call the OLDCARD driver's probe routine in the context that
: # it expects.  For OLDCARD these are implemented as pass throughs to the
: # device_{probe,attach} routines.  For NEWCARD they are implemented such
: # such that probe becomes strictly a matching routine and attach does both
: # the old probe and old attach.
: #
: # compat devices should use the following:
: #
: #       /* Device interface */
: #       DEVMETHOD(device_probe),        pccard_compat_probe),
: #       DEVMETHOD(device_attach),       pccard_compat_attach),
: #       /* Card interface */
: #       DEVMETHOD(card_compat_match,    foo_match),     /* newly written */
: #       DEVMETHOD(card_compat_probe,    foo_probe),     /* old probe */
: #       DEVMETHOD(card_compat_attach,   foo_attach),    /* old attach */
: 
: I think that card_compat_probe is used on OLDCARD. And on ed
: ed_pccard_probe is used too. So ed_pccard_probe can't use
: pccard_product_lookup function.
: 
: What do you think?

OLDCARD has been retro-fitted to allow the use of
pccard_product_lookup.  If that isn't working, the bug should be fixed
there.  It has been a long time since I have built and run an oldcard
kernel.  I kept meaning to get back to this bug, and appologize for my
lack of action on it.

The patch in this report might fix OLDCARD, but seem to break it for
NEWCARD, which is why I never applied them.

What is failing in the pccard_product_lookup function?

Warner

: Thanks.
: 
: >>>>> On Tue, 30 Aug 2005 18:20:00 GMT
: >>>>> FreeBSD-gnats-submit at FreeBSD.org said:
: > 
: > Thank you very much for your problem report.
: > It has the internal identification `kern/85493'.
: > The individual assigned to look at your
: > report is: freebsd-bugs. 
: > 
: > You can access the state of your problem report at any time
: > via this link:
: > 
: > http://www.freebsd.org/cgi/query-pr.cgi?pr=85493
: > 
: > >Category:       kern
: > >Responsible:    freebsd-bugs
: > >Synopsis:       OLDCARD can't probe ed driver
: > >Arrival-Date:   Tue Aug 30 18:20:00 GMT 2005
: 
: