misc/104854: "make release" custom kernel unsuccessful

[Sam Leffler]

Ruslan Ermilov wrote:
> On Fri, Oct 27, 2006 at 11:36:49AM +0200, Helmut Schneider wrote:
>> Well, then either I do not understand that design, or I do something 
>> completely wrong (if so I appologize):
>>
>> mkdir ${RD}/kernels
>> for i in ${KERNELS_BASE} ${KERNELS}; do \
>>    mkdir -p ${RD}/kernels/$${i}; \
>> done
>>
>> KERNELS_BASE is set to $MY_CUSTOM_KERNEL.
>> KERNELS is not mandatory and never set, so it is empty.
>>
>> => the only directory which is created is $MY_CUSTOM_KERNEL. The directory 
>> GENERIC will not be created.
>>
>> # Build boot and install floppies.
>> floppies.1:
>>        @gzip -9nc ${RD}/kernels/GENERIC/kernel > ${RD}/kernels/kernel.gz
>>
>> fails.
>>
>> => make release fails.
>>
>> make CHROOTDIR=/home/release CVSROOT=/usr BUILDNAME=6.1-RELEASE 
>> RELEASETAG=RELENG_6_1 EXTPORTSDIR=/usr/ports EXTSRCDIR=/usr/src 
>> KERNELS_BASE=IBM_HS20_SMP NODOC=YES NOPORTS=YES MAKE_ISOS=YES release
>>
>> Do I have to set KERNELS=$CUSTOM_KERNEL instead of 
>> KERNELS_BASE=$CUSTOM_KERNEL? ("make release" takes ages so I was not able 
>> to test that by now) 
> 
> On Fri, Oct 27, 2006 at 11:43:22AM +0200, Helmut Schneider wrote:
>> Sorry, forget that one, wasn't able to read the full posting (especially 
>> the part of man release)... :( 
> 
> :-)  I agree that there's still a bug in release/Makefile: it
> allows to override KERNELS_BASE but assumes later that GENERIC
> is always part of it.  A proper fix is to make KERNELS_BASE not
> overridable.  Sam, do you remember why you made it overridable?

Sorry, I do not recall.  John Baldwin was involved too I believe; maybe
he remembers.

	Sam