conf/106009: Fix pppoed startup script to process multiply
interfaces
Dennis Yusupoff
dyr at homelink.ru
Wed Nov 29 03:50:20 PST 2006
>Number: 106009
>Category: conf
>Synopsis: Fix pppoed startup script to process multiply interfaces
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 29 11:50:18 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Dennis Yusupoff
>Release: 6.1-RELEASE-p10
>Organization:
Ozerki.net ISP
>Environment:
FreeBSD nas4.ozerki.net 6.1-STABLE FreeBSD 6.1-STABLE #0: Tue Jul 4 14:11:56 MSD 2006 root at nas4.ozerki.net:/usr/obj/usr/src/sys/NAS4 i386
>Description:
By default, startup script /etc/rc.d/pppoed can not handle starting pppoed daemon at some interfaces. It's a pity and important, that's why we fix this script as writen below
>How-To-Repeat:
/etc/rc.d/pppoed start, then you have more than one interface in /etc/rc.conf string "pppoed_interface="xxx" "
>Fix:
===
#!/bin/sh
#
# $FreeBSD: src/etc/rc.d/pppoed,v 1.3 2004/10/07 13:55:26 mtm Exp $
#
# PROVIDE: pppoed
# REQUIRE: NETWORKING
# BEFORE: DAEMON
# KEYWORD: nojail
# Evseev/EBCEEB: pppoe_interface can contain multiple values
. /etc/rc.subr
name="pppoed"
rcvar="`set_rcvar`"
start_cmd="pppoed_start"
# XXX stop_cmd will not be straightforward
stop_cmd=":"
pppoed_start()
{
if [ -n "${pppoed_provider}" ]; then
pppoed_flags="${pppoed_flags} -p ${pppoed_provider}"
fi
echo 'Starting pppoed'
_opts=$-; set -f
for iface in ${pppoed_interface}; do
/usr/libexec/pppoed ${pppoed_flags} $iface
done
set +f; set -${_opts}
}
load_rc_config $name
run_rc_command "$1"
===
or diff:
nas4# diff -ua /etc/rc.d.OFF/pppoed /etc/rc.d/pppoed
--- /etc/rc.d.OFF/pppoed Sun May 8 11:05:12 2005
+++ /etc/rc.d/pppoed Thu Jul 27 14:41:07 2006
@@ -1,6 +1,6 @@
#!/bin/sh
#
-# $FreeBSD: src/etc/rc.d/pppoed,v 1.2.2.1 2004/10/10 09:50:54 mtm Exp $
+# $FreeBSD: src/etc/rc.d/pppoed,v 1.3 2004/10/07 13:55:26 mtm Exp $
#
# PROVIDE: pppoed
@@ -8,6 +8,8 @@
# BEFORE: DAEMON
# KEYWORD: nojail
+# Evseev/EBCEEB: pppoe_interface can contain multiple values
+
. /etc/rc.subr
name="pppoed"
@@ -23,7 +25,9 @@
fi
echo 'Starting pppoed'
_opts=$-; set -f
- /usr/libexec/pppoed ${pppoed_flags} ${pppoed_interface}
+ for iface in ${pppoed_interface}; do
+ /usr/libexec/pppoed ${pppoed_flags} $iface
+ done
set +f; set -${_opts}
}
===
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-bugs
mailing list