kern/105054: vge driver sends VLAN IDs in wrong endian.

[Yo Its Me Remember]

The following reply was made to PR kern/105054; it has been noted by GNATS.

From: Yo Its Me Remember <yoitsmeremember at yahoo.com>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/105054: vge driver sends VLAN IDs in wrong endian.
Date: Thu, 2 Nov 2006 08:59:48 -0800 (PST)

 --0-1761971943-1162486788=:81955
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: 8bit
 
 No, the input VLAN tags are fine, as I mentioned in the description.  Your patch changes them so that they're now in big endian instead of little endian, causing another bug.  As far as casting to a uint16_t instead of using htole16, I would think big endian systems would still need to hand the card output tags in little endian.  Not really sure though since I don't have any big endian systems to test it.
 
 Either way, the second half of the patch will work just fine for little endian systems, just leave the input tag ntohs() there.
 
 Thanks,
     Ian
 
  
 ---------------------------------
 Get your email and see which of your friends are online - Right on the  new Yahoo.com
 --0-1761971943-1162486788=:81955
 Content-Type: text/html; charset=iso-8859-1
 Content-Transfer-Encoding: 8bit
 
 No, the input VLAN tags are fine, as I mentioned in the description.&nbsp; Your patch changes them so that they're now in big endian instead of little endian, causing another bug.&nbsp; As far as casting to a uint16_t instead of using htole16, I would think big endian systems would still need to hand the card output tags in little endian.&nbsp; Not really sure though since I don't have any big endian systems to test it.<br><br>Either way, the second half of the patch will work just fine for little endian s ystems, just leave the input tag ntohs() there.<br><br>Thanks,<br>&nbsp;&nbsp;&nbsp; Ian<br><p>&#32;
 
 <hr size=1>Get your email and see which of your friends are online - Right on the <a href="http://us.rd.yahoo.com/evt=42973/*http://www.yahoo.com/preview"> new Yahoo.com</a>
 
 --0-1761971943-1162486788=:81955--