kern/98091: [ patch ] Makefile style of mfi kernel module broke the WARNS/NO_WERROR logic

Ruslan Ermilov ru at FreeBSD.org
Mon May 29 08:45:55 PDT 2006


Synopsis: [ patch ] Makefile style of mfi kernel module broke the WARNS/NO_WERROR logic

Responsible-Changed-From-To: freebsd-bugs->scottl
Responsible-Changed-By: ru
Responsible-Changed-When: Mon May 29 15:40:27 UTC 2006
Responsible-Changed-Why: 
Scott, please fix it as per style.Makefile manpage:

     o   Do not use GCCisms (such as -g and -Wall) in CFLAGS.

     o   WARNS comes before CFLAGS, as it is basically a CFLAGS modifier.  It
         comes before CFLAGS rather than after CFLAGS so it does not get lost
         in a sea of CFLAGS statements as WARNS is an important thing.  The
         usage of WARNS is spelled ``WARNS?= '', so that it may be overridden
         on the command line or in make.conf(5).

http://www.freebsd.org/cgi/query-pr.cgi?pr=98091


More information about the freebsd-bugs mailing list