kern/94992: pfctl complains about ALTQ missing

[Daniel O'Connor]

>Number:         94992
>Category:       kern
>Synopsis:       pfctl complains about ALTQ missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 27 04:00:31 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Daniel O'Connor
>Release:        FreeBSD 6.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD cain.gsoft.com.au 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Wed Nov 2 19:07:38 UTC 2005 root at rat.samsco.home:/usr/obj/usr/src/sys/GENERIC amd64


>Description:
pfctl complains about ALTQ support being missing from the kernel yet it is not in
GENERIC. IMO it should only complain if you are trying to do something ALTQ related.

>How-To-Repeat:
pfctl -s rules

>Fix:
Index: contrib/pf/pfctl/pfctl.c
===================================================================
RCS file: /usr/local/ncvs/src/contrib/pf/pfctl/pfctl.c,v
retrieving revision 1.6
diff -u -r1.6 pfctl.c
--- contrib/pf/pfctl/pfctl.c    3 May 2005 16:55:20 -0000       1.6
+++ contrib/pf/pfctl/pfctl.c    27 Mar 2006 03:51:31 -0000
@@ -1510,7 +1510,7 @@

        if (ioctl(dev, DIOCGETALTQS, &pa)) {
                if (errno == ENODEV) {
-                       if (!(opts & PF_OPT_QUIET))
+                       if (opts & PF_OPT_VERBOSE)
                                fprintf(stderr, "No ALTQ support in kernel\n"
                                    "ALTQ related functions disabled\n");
                        return (0);


>Release-Note:
>Audit-Trail:
>Unformatted: