misc/94409: sysinstall: add geom.debugflags-note to disklabel error

[Markus Oestreicher]

>Number:         94409
>Category:       misc
>Synopsis:       sysinstall: add geom.debugflags-note to disklabel error
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 13 15:20:30 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Markus Oestreicher
>Release:        FreeBSD 6.1
>Organization:
>Environment:
FreeBSD oeo.local 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #1: Sun Mar 12 00:05:14 CET 2006     root at oeo.local:/usr/obj/usr/src/sys/OEO  i386

>Description:
When using sysinstall to edit the disk configuration of a running system 
you get the error message "Unable to write data" because GEOM blocks the 
low-level access.

The attached patch changes the error message to give a possible solution.





>How-To-Repeat:
Use sysinstall on a running system
Try to change anything in the "Configure / Labels" section

>Fix:

--- disks.c.orig        Mon Mar 13 15:56:56 2006
+++ disks.c     Mon Mar 13 16:01:07 2006
@@ -879,7 +879,9 @@

        msgNotify("Writing partition information to drive %s", d->name);
        if (!Fake && Write_Disk(d)) {
-           msgConfirm("ERROR: Unable to write data to disk %s!", d->name);
+           msgConfirm("ERROR: Unable to write data to disk %s!\n\n"
+               "To edit the labels on a running system set\n"
+               "sysctl kern.geom.debugflags=16 and try again.", d->name);
            return DITEM_FAILURE;
        }
     }

>Release-Note:
>Audit-Trail:
>Unformatted: