kern/98529: [netgraph] False "ng_generic_msg: number of nodes changed" report

[Michael Heyman]

>Number:         98529
>Category:       kern
>Synopsis:       [netgraph] False "ng_generic_msg: number of nodes changed" report
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 05 14:10:20 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Michael Heyman
>Release:        FreeBSD 7-CURRENT
>Organization:
>Environment:
>Description:
In ng_base.c around line 2658 there can be a false error report saying "ng_generic_msg: number of nodes changed". This report occurs when the response message fills up.

The false report occurs when the response message is full and would not receive any more information even though there are still nodes in ng_nodelist to scan.

>How-To-Repeat:

>Fix:
Moving the check down 4 lines to below the "if(NG_NODE_NOT_VALID(node))" and "if(!unamed && (!NG_NODE_HAS_NAME(node)))" conditionals will remove the false error report.


>Release-Note:
>Audit-Trail:
>Unformatted: