kern/100046: [patch] mutex lock errors in drivers

[Beyond Luo]

>Number:         100046
>Category:       kern
>Synopsis:       [patch] mutex lock errors in drivers
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 11 01:40:14 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Beyond Luo
>Release:        6.0
>Organization:
Institute of Software, Chinese Academy of Science
>Environment:
FreeBSD Earth.Earth 6.0-RELEASE FreeBSD 6.0-RELEASE #2: Tue Feb 28 02:32:45 UTC 2006     root at guhao.fsd.iscas:/usr/obj/usr/src/sys/CAS-EARTH  i386
(We are doing some work on FreeBSD6.0)
>Description:
The following three files do not do mtx_unlock before return:
  /usr/src/sys/cam/scsi/scsi_cd.c (#line 594)
  /usr/src/sys/cam/scsi/scsi_da.c (#line 1004)
  /usr/src/sys/dev/aac/aac_cam.c (#line 417)

(Detected by a bug-check tool we are developping.)


>How-To-Repeat:

>Fix:
  following mtx_unlock should be added respectively:
  mtx_unlock(&Giant);
  mtx_unlock(&Giant);
  mtx_unlock(&sc->aac_io_lock);
>Release-Note:
>Audit-Trail:
>Unformatted: