kern/99676: The strange expression in if_ural.c::ural_set_chan()

KIYOHARA Takashi kiyohara at netbsd.org
Sat Jul 1 08:30:20 UTC 2006


>Number:         99676
>Category:       kern
>Synopsis:       The strange expression in if_ural.c::ural_set_chan()
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 01 08:30:18 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     KIYOHARA Takashi
>Release:        -current
>Organization:
>Environment:
>Description:
I look and think strange expression in if_ural.c::ural_set_chan().  I guess the "i<..." is an accident.

if_ural.c::ural_set_chan() ---

	/* dual-band RF */
	case RAL_RF_5222:
		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
                           ^^^^^
		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

--- if_ural.c::ural_set_chan()
>How-To-Repeat:

>Fix:

	/* dual-band RF */
	case RAL_RF_5222:
-		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
+		for (i = 0; ural_rf5222[i].chan != chan; i++);

		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list