kern/91720: pxeboot always tries to do an rpc call to an nfs-server

[Ceri Davies]

The following reply was made to PR kern/91720; it has been noted by GNATS.

From: Ceri Davies <ceri at submonkey.net>
To: Ruben Kerkhof <ruben.kerkhof at gmail.com>
Cc: freebsd-gnats-submit at freebsd.org
Subject: Re: kern/91720: pxeboot always tries to do an rpc call to an nfs-server
Date: Sun, 15 Jan 2006 23:55:34 +0000

 --pWJxWxNlJUNgDlXi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Sun, Jan 15, 2006 at 06:03:57PM +0100, Ruben Kerkhof wrote:
 > Hi Ceri,
 > 
 > It does indeed do what I want, but the issue is that it takes a while for
 > pxeboot to notice that it can't mount nfs.
 > Since I compiled the loader with LOADER_TFTP_SUPPORT, I don't think it
 > should try to do an rpc call in the first place.
 > This slows down the booting process. Although the nfs mount error is
 > harmless, it makes people (like me) think there's something wrong.
 > 
 > If my memory is right, it behaved ok before patch 1.21 (
 > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/boot/i386/libi386/pxe.c.diff?r1=1.20&r2=1.21
 > )
 
 Hi Ruben,
 
 Thanks for the explanation.  I've attached a patch which sounds like it
 will fix this, but I don't have an environment to test either TFTP or
 NFS booting, so take it with a large pinch of salt.
 
 Ceri
 -- 
 That must be wonderful!  I don't understand it at all.
                                                   -- Alice
 
 --pWJxWxNlJUNgDlXi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="91720.diff"
 
 Index: libi386/Makefile
 ===================================================================
 RCS file: /usr/home/ncvs/src/sys/boot/i386/libi386/Makefile,v
 retrieving revision 1.37
 diff -u -r1.37 Makefile
 --- libi386/Makefile	24 Oct 2004 15:32:49 -0000	1.37
 +++ libi386/Makefile	15 Jan 2006 23:54:07 -0000
 @@ -10,6 +10,10 @@
  	i386_copy.c i386_module.c nullconsole.c pxe.c pxetramp.s \
  	time.c vidconsole.c amd64_tramp.S
  
 +.if defined(LOADER_TFTP_SUPPORT)
 +CFLAGS+=	-DLOADER_TFTP_SUPPORT
 +.endif
 +
  BOOT_COMCONSOLE_PORT?= 0x3f8
  CFLAGS+=	-DCOMPORT=${BOOT_COMCONSOLE_PORT}
  
 Index: libi386/pxe.c
 ===================================================================
 RCS file: /usr/home/ncvs/src/sys/boot/i386/libi386/pxe.c,v
 retrieving revision 1.22
 diff -u -r1.22 pxe.c
 --- libi386/pxe.c	17 Apr 2005 21:38:22 -0000	1.22
 +++ libi386/pxe.c	15 Jan 2006 23:48:39 -0000
 @@ -335,8 +335,10 @@
      if (pxe_opens > 0)
  	return(0);
  
 +#ifdef LOADER_NFS_SUPPORT
      /* get an NFS filehandle for our root filesystem */
      pxe_setnfshandle(rootpath);
 +#endif
  
      if (pxe_sock >= 0) {
  
 
 --pWJxWxNlJUNgDlXi--