bin/93145: [PATCH] 6.1-BETA1 DHCP config error

[Ulf Lilleengen]

The following reply was made to PR bin/93145; it has been noted by GNATS.

From: Ulf Lilleengen <lulf at stud.ntnu.no>
To: FreeBSD-gnats-submit at FreeBSD.org
Cc:  
Subject: Re: bin/93145: [PATCH] 6.1-BETA1 DHCP config error
Date: Fri, 10 Feb 2006 19:57:18 +0100

 --pWyiEgJYm5f9v55/
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On fre, feb 10, 2006 at 07:46:08 +0100, Ulf Lilleengen wrote:
 >=20
 > >Number:         93145
 > >Category:       bin
 > >Synopsis:       [PATCH] 6.1-BETA1 DHCP config error
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:       =20
 > >Keywords:      =20
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Fri Feb 10 18:50:02 GMT 2006
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Ulf Lilleengen
 > >Release:        FreeBSD 7.0-CURRENT i386
 > >Organization:
 > >Environment:
 > System: FreeBSD vimes.studby.ntnu.no 7.0-CURRENT FreeBSD 7.0-CURRENT #4: =
 Wed Jan 25 21:16:02 CET 2006 root at vimes.studby.ntnu.no:/usr/obj/usr/src/sys=
 /VIMES i386
 >=20
 >=20
 > =09
 > >Description:
 > 	When i try to install 6.1-BETA1 and choose to use DHCP to configure my
 > 	rl0 interface, i get an error saying "ifconfig: DHCP: bad value" coming
 > 	from the installer trying to run ifconfig rl0 DHCP.
 >=20
 > 	I looked at the code in network.c in sysinstall, and found a difference
 > 	between CURRENT and BETA1, which was an strstr check being changed.
 > 	Patch added below.
 > =09
 > >How-To-Repeat:
 > 	Try install 6.1-BETA1 and configure network interface with DHCP
 > =09
 > >Fix:
 >=20
 > =09
 >=20
 > --- sysinstall_dhcpconfig.diff begins here ---
 > Index: network.c
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /home/cvs/ncvs/src/usr.sbin/sysinstall/network.c,v
 > retrieving revision 1.51
 > diff -u -r1.51 network.c
 > --- network.c	1 Nov 2002 02:05:05 -0000	1.51
 > +++ network.c	10 Feb 2006 18:37:24 -0000
 > @@ -126,7 +126,7 @@
 >      snprintf(ifconfig, 255, "%s%s", VAR_IFCONFIG, dev->name);
 >      cp =3D variable_get(ifconfig);
 >      if (cp) {
 > -	if (strcmp(cp, "DHCP")) {
 > +	if (strcmp(cp, "DHCP") =3D=3D NULL) {
 >  	    msgDebug("ifconfig %s %s\n", dev->name, cp);
 >  	    i =3D vsystem("ifconfig %s %s", dev->name, cp);
 >  	    if (i) {
 > --- sysinstall_dhcpconfig.diff ends here ---
 >=20
 >=20
 When i look more at it, strcmp should be replaced with strstr...
 --=20
 Mvh Ulf Lilleengen
 
 --pWyiEgJYm5f9v55/
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (GNU/Linux)
 
 iD8DBQFD7OINCILg8nMIdCURAigkAJ9oUBPTKzk7DIXNDp83lmVL514XbQCeMeas
 YduWzyEWgyeJUxIg+86ri5E=
 =Trcp
 -----END PGP SIGNATURE-----
 
 --pWyiEgJYm5f9v55/--