kern/106657: src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum

Dr. Markus Waldeck waldeck at gmx.de
Wed Dec 13 00:00:22 PST 2006


>Number:         106657
>Category:       kern
>Synopsis:       src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 13 08:00:18 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Dr. Markus Waldeck
>Release:        7.0-CURRENT-200611
>Organization:
>Environment:
FreeBSD fbh 7.0-CURRENT-200611 FreeBSD 7.0-CURRENT-200611
root at fb:/usr/src/sys/i386/compile/FB70B01 i386
>Description:
I tried to figure out what is the purpose of net.inet.udp.checksum.

I found in src/sys/netinet/udp_usrreq.c following lines

#ifndef	COMPAT_42
static int	udpcksum = 1;
#else
static int	udpcksum = 0;		/* XXX */
#endif

I expect that net.inet.udp.checksum is a 4.2BSD compatibility feature.

But /* XXX */ is NOT a very sufficient comment!
>How-To-Repeat:
less src/sys/netinet/udp_usrreq.c
>Fix:
add a useful comment
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list