kern/80742: [PATCH] Local DoS in sys/compat/pecoff (+ other
maxim at macomnet.ru
Sat May 7 19:10:05 PDT 2005
The following reply was made to PR kern/80742; it has been noted by GNATS.
From: Maxim Konovalov <maxim at macomnet.ru>
To: "Wojciech A. Koszek" <dunstan at freebsd.czest.pl>
Cc: bug-followup at freebsd.org
Subject: Re: kern/80742: [PATCH] Local DoS in sys/compat/pecoff (+ other
Date: Sun, 8 May 2005 06:01:50 +0400 (MSD)
> Specification doesn't remind about possibility of negative values of PEOFS, so this
> variable might be declared as "unsigned". My patch contains also:
> - fix for bug
> - style(9) fixes/consistent malloc checking
> - proper error handling
> - DPRINTF from .c file -> PE_DEBUG in .h file with more readable output.
> - DEBUG -> PECOFF_DEBUG, since debugging code is enabled when PECOFF_DEBUG
> is defined (not DEBUG)
Please, please don't mix style(9) and functional changes in a one
diff, it's very hard to read it. Personally, I don't think they are
needed at all.
More information about the freebsd-bugs