bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if' option of gettytab(5) and don't print initial message from a file (by default /etc/issue) before the login prompt

Rostislav Krasny rosti.bsd at gmail.com
Sat May 7 08:50:07 PDT 2005


The following reply was made to PR bin/80732; it has been noted by GNATS.

From: Rostislav Krasny <rosti.bsd at gmail.com>
To: Maxim Konovalov <maxim at macomnet.ru>
Cc: bug-followup at freebsd.org
Subject: Re: bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if' option of gettytab(5) and don't print initial message from a file (by default /etc/issue) before the login prompt
Date: Sat, 7 May 2005 17:41:58 +0200

 On 5/7/05, Maxim Konovalov <maxim at macomnet.ru> wrote:
 > Does your patch correlate with bin/23562?
 >=20
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dbin/23562
 
 The bin/23562 is about same bugs of getty(8) and telnetd(8). It have
 very old patch for telnetd(8) and no patch for getty(8).
 
 The history of the patch in bin/23562 is mysterious. Originally it was
 introduced in bin/6492 and then commited, many years ago:
 http://www.freebsd.org/cgi/cvsweb.cgi/src/libexec/telnetd/Attic/telnetd.c.d=
 iff?r1=3D1.7.2.4&r2=3D1.7.2.5
 Three years later (August 2001) it was removed during: "Feature
 merging and diff reduction between this code and crypto telnet":
 http://www.freebsd.org/cgi/cvsweb.cgi/src/libexec/telnetd/Attic/telnetd.c.d=
 iff?r1=3D1.29&r2=3D1.30
 But the removing was not complete. telnetd.c still includes
 <sys/mman.h> that had been need for mmap() and munmap() and manual
 page of telnetd(8) still states that 'if' option of gettytab is
 supported. The patch in bin/23562 was proposed in February 2001, i.e.
 before it was removed in revision 1.30.
 In July 2003 the sources of telnetd(8) were moved to
 src/contrib/telnet where the revision numbering is different.
 
 Personally I think my patch ot telnetd.c is better and the the
 inclusion of <sys/mman.h> could be also removed from the telnetd.c as
 needless.


More information about the freebsd-bugs mailing list