kern/82413: Kernel panic in ksocket netgraph module

[Stanislav Sedov]

>Number:         82413
>Category:       kern
>Synopsis:       Kernel panic in ksocket netgraph module
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 19 12:50:22 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Stanislav Sedov
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
310.ru [Tridesyatoe]
>Environment:
System: FreeBSD stalingrad.realnet 6.0-CURRENT FreeBSD 6.0-CURRENT #134: Sat Jun 18 14:21:40 MSD 2005 root at stalingrad.realnet:/work/src/fbsd-cur/src/sys/i386/compile/DESKTOP i386


	
>Description:
	When using ksocket netgraph module(in mpd pptp for example),
kernel panic occur. Other modules aren't affected.
>How-To-Repeat:
	For example, run mpd with following config and try to download some
data via its interface.
--- mpd.conf--
default:
        load vpn

vpn:
        new -i ng0 vpn vpn
        set iface disable on-demand
        set iface addrs 10.3.81.2
        set iface idle 0
        set iface route 192.168.1.1/0
        set bundle disable multilink
        set bundle authname "user"
        set bundle password "password"
        set link yes acfcomp protocomp
        set link no pap
        set link yes chap
        set link mtu 1460
        set link enable no-orig-auth
        set ipcp yes vjcomp
        set ccp yes mppc
        set ccp yes mpp-e40
        set ccp yes mpp-e128
        set bundle enable crypt-reqd
        set ccp yes mpp-stateless
        open

--------------
>Fix:

I'm not familar with netgraph code, so I can't figure out where is a problem.
However, when using non-queue function in ng_ksocket_incoming, everything
works well. It seems the problem in queue realization of ng_send_fn1
in ng_base.c or in ng_ksocket_incoming2.
----------------------------------------------------
--- ng_ksocket.c        Sun Jun 19 16:29:30 2005
+++ ng_ksocket.c.orig   Sun Jun 19 16:29:18 2005
@@ -1013,7 +1013,7 @@

        wait = (waitflag & M_WAITOK) ? NG_WAITOK : 0;
        ng_send_fn1(node, NULL, &ng_ksocket_incoming2, so, waitflag,
-           wait);
+           wait | NG_QUEUE);
 }
-------------------------------------------------------


>Release-Note:
>Audit-Trail:
>Unformatted: