kern/82188: [patch] ng_fec interface not running after assigning an address

[Stikheev Andrew]

>Number:         82188
>Category:       kern
>Synopsis:       [patch] ng_fec interface not running after assigning an address
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 13 07:50:10 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Stikheev Andrew
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD sand.zuzino.mipt.ru 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Sun Jun 12 02:16:10 MSD 2005 sand at sand.zuzino.mipt.ru:/usr/obj/usr/src/sys/MYKERNEL i386


	
>Description:
After creating fec interface and assigning address it's not in the running state
,
only in the up state. I should say 'ifconfig fec0 up' or run promiscuous mode   
to run it:

After startup:

fec0: flags=8803<UP,BROADCAST,SIMPLEX,MULTICAST> mtu 1500
fxp0: flags=18843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,POLLING> mtu 1500
        options=48<VLAN_MTU,POLLING>
fxp2: flags=18843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,POLLING> mtu 1500
        options=48<VLAN_MTU,POLLING>

sand at video:~# ifconfig fec0 up
sand at video:~# fec0: port fxp0 in bundle is up
fec0: port fxp2 in bundle is up

sand at video:~# ifconfig fec0   
fec0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
 
>How-To-Repeat:
	
>Fix:

--- ng_fec.c    Mon Jun 13 10:10:06 2005
+++ ng_fec.c.new        Mon Jun 13 10:14:04 2005
@@ -697,6 +697,8 @@ ng_fec_ioctl(struct ifnet *ifp, u_long c
 
        /* These two are mostly handled at a higher layer */
        case SIOCSIFADDR:
+               ifp->if_flags |= (IFF_UP | IFF_RUNNING);
+               ifp->if_flags &= ~(IFF_OACTIVE);
        case SIOCGIFADDR:
        case SIOCSIFMTU:
                error = ether_ioctl(ifp, command, data);
>Release-Note:
>Audit-Trail:
>Unformatted: