misc/76494: passwd does not indicate a successful change - causes problems with Samba password sync

[Ceri Davies]

The following reply was made to PR misc/76494; it has been noted by GNATS.

From: Ceri Davies <ceri at submonkey.net>
To: Rob Mason <rob at bsdbox.homeunix.com>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: misc/76494: passwd does not indicate a successful change - causes problems with Samba password sync
Date: Thu, 20 Jan 2005 10:17:50 +0000

 On Thu, Jan 20, 2005 at 09:46:31AM +0000, Rob Mason wrote:
 
 > The passwd command on 4-STABLE output the text "passwd: done" when a
 > password was changed.  This feature is used by the Samba-3 port to
 > indicate a successful change in the 'passwd chat' config option.
 > 5-STABLE does not indicate that the password change is successful
 
 What's wrong with a return status?
 
 > Apply the following patch:
 > 
 > *** 157,164 ****
 > --- 157,165 ----
 >         /* set new password */
 >         pam_err = pam_chauthtok(pamh, 0);
 >         pam_check("pam_chauthtok");
 > 
 >    end:
 > +       if (pam_err == PAM_SUCCESS) fprintf(stderr, "Password Changed\n");
 >         pam_end(pamh, pam_err);
 >         exit(pam_err == PAM_SUCCESS ? 0 : 1);
 >   }
 
 It also strikes me that this is not the same as the 4.X output; why?
 
 Ceri