bin/76169: [PATCH] Add PAM support to cvs pserver
Giorgos Keramidas
keramida at ceid.upatras.gr
Wed Jan 12 13:20:25 PST 2005
The following reply was made to PR bin/76169; it has been noted by GNATS.
From: Giorgos Keramidas <keramida at ceid.upatras.gr>
To: Dan Nelson <dnelson at allantgroup.com>
Cc: bug-followup at freebsd.org
Subject: Re: bin/76169: [PATCH] Add PAM support to cvs pserver
Date: Wed, 12 Jan 2005 23:17:32 +0200
On 2005-01-12 12:15, Dan Nelson <dnelson at allantgroup.com> wrote:
> Most of the base services have been PAM-ified, but cvs is a notable
> exception. CVS 1.12 will have PAM support, but I don't know when 1.12
> will be declared stable. The following patch is based on Steve
> McIntyre's 1.11 patch at
> http://ccvs.cvshome.org/issues/show_bug.cgi?id=44 .
CVS is contrib software, so I don't know if we can just pull the files
off the vendor branch so easily. But I noticed a small nit, that you
may want to fix in the diff:
> --- gnu/usr.bin/cvs/cvs/Makefile 6 Aug 2004 07:27:03 -0000 1.48
> +++ gnu/usr.bin/cvs/cvs/Makefile 5 Jan 2005 18:25:50 -0000
:
> DPADD= ${LIBCVS} ${LIBDIFF} ${LIBGNUREGEX} ${LIBMD} ${LIBCRYPT} ${LIBZ}
> -LDADD= ${LIBCVS} ${LIBDIFF} -lgnuregex -lmd -lcrypt -lz
> +LDADD= ${LIBCVS} ${LIBDIFF} -lgnuregex -lmd -lcrypt -lz -lpam
Adding libraries in LDADD should also update DPADD, IIRC.
The fix is simple: add ${LIBPAM} to DPADD too.
More information about the freebsd-bugs
mailing list