bin/75946: cosmetic typo in /etc/rc.subr: check_pidfile()

Finn zero at gddn.org
Sat Jan 8 08:00:55 PST 2005


>Number:         75946
>Category:       bin
>Synopsis:       cosmetic typo in /etc/rc.subr: check_pidfile()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 08 16:00:52 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Finn
>Release:        CURRENT RELENG_5 RELENG_5_3
>Organization:
>Environment:
>Description:
In /etc/rc.subr there is a '(' vs. '{' typo in the function check_pidfile() line 206. Since it appears in a debug message in 
double quotes, it has no effect on functionality.

>How-To-Repeat:

>Fix:
--- etc/rc.subr,~
+++ etc/rc.subr
@@ -192,19 +192,19 @@
 check_pidfile()
 {
 	_pidfile=$1
 	_procname=$2
 	_interpreter=$3
 	if [ -z "$_pidfile" -o -z "$_procname" ]; then
 		err 3 'USAGE: check_pidfile pidfile procname [interpreter]'
 	fi
 	if [ ! -f $_pidfile ]; then
 		debug "pid file ($_pidfile): not readable."
 		return
 	fi
 	read _pid _junk < $_pidfile
 	if [ -z "$_pid" ]; then
-		debug "pid file {$_pidfile): no pid in file."
+		debug "pid file ($_pidfile): no pid in file."
 		return
 	fi
 	_find_processes $_procname ${_interpreter:-.} '-p '"$_pid"
 }

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list