bin/75786: typo and useless part in /etc/pccard_ether

[Radko Keves]

>Number:         75786
>Category:       bin
>Synopsis:       typo and useless part in /etc/pccard_ether
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 04 09:50:25 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Radko Keves
>Release:        FreeBSD 5.3-RELEASE-p1 i386
>Organization:
nothing
>Environment:
FreeBSD gaila 5.3-RELEASE-p1 FreeBSD 5.3-RELEASE-p1 #0: Wed Dec 1 01:00:
40 CET 2004 root@:/usr/src/sys/i386/compile/angel i386
>Description:
        There is a typo in /etc/pccard_ether file
        and one part which is probably not used in
        this moment.
        
        As is said in /etc/devd.conf
        For ethernet like devices, the default is to run dhclient.        Due to a historical accident, this script is called pccard_ether.

        In this moment pccard_ether isn't working,
        this can be problem in many cases. 

>How-To-Repeat:
      Run:
/etc/pccard_ether <nic-name> <start|stop>

>Fix:
--- /etc/pccard_ether   Tue Nov  9 15:34:37 2004
+++ /etc/pccard_ether.fixed     Sat Jan  1
14:04:42 2005
@@ -123,18 +123,8 @@

 interface=$1
 shift
-startstop=$1
+startstop=$2
 shift
-
-case ${pccard_ifconfig} in
-[Nn][Oo] | '')
-       expr "${removable_interfaces}" : ".*${interface}" > /dev/null || exit 0
-       ;;
-*)
-       # Backward compatible
-       eval ifconfig_${interface}=\${pccard_ifconfig}
-       ;;
-esac

>Release-Note:
>Audit-Trail:
>Unformatted: