kern/85239: assigning an address to ng_fec(4) iface causes panic

[Maksim Yevmenkin]

The following reply was made to PR kern/85239; it has been noted by GNATS.

From: Maksim Yevmenkin <maksim.yevmenkin at gmail.com>
To: "Evgueni V. Gavrilov" <aquatique at rusunix.org>
Cc: bug-followup at freebsd.org, Brooks Davis <brooks at one-eyed-alien.net>
Subject: Re: kern/85239: assigning an address to ng_fec(4) iface causes panic
Date: Wed, 24 Aug 2005 09:27:21 -0700

 Evgueni,
 
 > I've applied Maksim's patch (with some modifications since 6.0-BETA3
 > holds ng_fec.c 1.18, not 1.20)
 
 ok. just to verify, you have applied the second patch? right? as
 Brooks pointed out the first patch did not make required change in
 ng_fec_ioctl() (call to ng_fec_init() was still using ifp pointer
 instead of priv pointer).
 
 > The short response: it works finally :)
 >=20
 > But assigning an address to fec iface being down causes frezze, so I
 > made following startup:
 
 i can not reproduce the freeze here :( i did simple test (below).
 unfortunately i do not have hardware to recreate your setup here :(
 
 can you drop into the debugger (ctrl+alt+esc) and try to get a stack
 trace? if you can not - could you please try to put some printf's into
 /sys/netgraph/ng_fec.c to see where it locks up?
 
 beetle# uname -a
 FreeBSD beetle.digisle.com 7.0-CURRENT FreeBSD 7.0-CURRENT #31: Tue
 Aug  9 15:51:44 PDT 2005   =20
 max at beetle.digisle.com:/usr/obj/usr/src/sys/GENERIC  i386
 
 beetle# ifconfig fec0
 fec0: flags=3D8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
         inet6 fe80::211:43ff:fe54:22c9%fec0 prefixlen 64 scopeid 0x4=20
         ether 00:00:00:00:00:00
         media: Ethernet none
         status: no carrier
 
 beetle# ifconfig fec0 inet 192.168.1.1 netmask 255.255.255.0
 beetle# ifconfig fec0
 fec0: flags=3D8803<UP,BROADCAST,SIMPLEX,MULTICAST> mtu 1500
         inet6 fe80::211:43ff:fe54:22c9%fec0 prefixlen 64 scopeid 0x4=20
         inet 192.168.1.1 netmask 0xffffff00 broadcast 192.168.1.255
         ether 00:00:00:00:00:00
         media: Ethernet none
         status: no carrier
 
 beetle# ifconfig fec0 down
 beetle# ifconfig fec0
 fec0: flags=3D8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
         inet6 fe80::211:43ff:fe54:22c9%fec0 prefixlen 64 scopeid 0x4=20
         inet 192.168.1.1 netmask 0xffffff00 broadcast 192.168.1.255
         ether 00:00:00:00:00:00
         media: Ethernet none
         status: no carrier
 
 beetle# ifconfig fec0 delete
 beetle# ifconfig fec0=20
 fec0: flags=3D8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
         inet6 fe80::211:43ff:fe54:22c9%fec0 prefixlen 64 scopeid 0x4=20
         ether 00:00:00:00:00:00
         media: Ethernet none
         status: no carrier
 
 thanks,
 max