kern/80390: fstatfs() returns wrong flags or libexec/rtld-elf/rtld.c is broken

[Ian Dowse]

The following reply was made to PR kern/80390; it has been noted by GNATS.

From: Ian Dowse <iedowse at maths.tcd.ie>
To: Andre Albsmeier <Andre.Albsmeier at siemens.com>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: kern/80390: fstatfs() returns wrong flags or libexec/rtld-elf/rtld.c is broken 
Date: Wed, 27 Apr 2005 10:19:50 +0100

 In message <200504270652.j3R6qSxv038497 at curry.mchp.siemens.de>, Andre Albsmeier
  writes:
 >On a FreeBSD 5.4-STABLE system fstatfs() used on an NFS mounted
 >volume now returns the NFS mount option flags (as defined in
 >sys/nfsclient/nfsargs.h) instead of the "normal" filesystem
 >flags as defined in sys/sys/mount.h.
 
 I wonder if the following would be more appropriate? This change
 was made in the CSRG sources in March 1995, but the equivalent
 change was not made to FreeBSD when the NFSv3 import happened a few
 months later. Maybe there is something in the kernel that depends
 on getting the NFS flags this way though.
 
 Ian
 
 Index: nfs_vfsops.c
 ===================================================================
 RCS file: /dump/FreeBSD-CVS/src/sys/nfsclient/nfs_vfsops.c,v
 retrieving revision 1.172
 diff -u -r1.172 nfs_vfsops.c
 --- nfs_vfsops.c	24 Mar 2005 07:37:22 -0000	1.172
 +++ nfs_vfsops.c	27 Apr 2005 09:12:56 -0000
 @@ -266,7 +266,6 @@
  		goto nfsmout;
  	}
  	sfp = nfsm_dissect(struct nfs_statfs *, NFSX_STATFS(v3));
 -	sbp->f_flags = nmp->nm_flag;
  	sbp->f_iosize = nfs_iosize(nmp);
  	if (v3) {
  		sbp->f_bsize = NFS_FABLKSIZE;