bin/71917: selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked

[Rostislav Krasny]

>Number:         71917
>Category:       bin
>Synopsis:       selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 19 21:30:28 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Rostislav Krasny
>Release:        5.3-BETA4
>Organization:
>Environment:
FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27 IDT 2004     root at localhost:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When one select "All" on some of the "Distributions" menus of
sysinstall(8) no distribution is marked but actually all of them are
selected for installation. It can confuse one during a new system
installation. Following patch fixes this problem.
>How-To-Repeat:
If you want test this patch or repeat the problem before that on already installed system try following scenario before and after applying the patch to your source:

1. run 'sysinstall' as a root
2. go to "Custom | Distributions" or to "Custom | Distributions | Custom" menu
3. select "All" on the menu and see what distributions are marked after that
>Fix:
--- dist.c.prev Sat Sep 18 17:37:01 2004
+++ dist.c      Sat Sep 18 17:38:06 2004
@@ -291,7 +291,7 @@
     XOrgDists = DIST_XORG_ALL;
     i = distMaybeSetPorts(self);
     distVerifyFlags();
-    return i;
+    return i | DITEM_REDRAW;
 }

 static int


P.S. If this patch is correct it should be commited to 5.3 before the
release, IMHO.
>Release-Note:
>Audit-Trail:
>Unformatted: