bin/71773: [patch] genericize.pl -c misses some comments

Antoine Brodin antoine.brodin at laposte.net
Wed Sep 15 11:50:36 PDT 2004


>Number:         71773
>Category:       bin
>Synopsis:       [patch] genericize.pl -c misses some comments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 15 18:50:29 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Antoine Brodin
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD massena-4-82-67-196-50.fbx.proxad.net 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Mon Sep 13 17:05:28 CEST 2004 root at massena-4-82-67-196-50.fbx.proxad.net:/usr/obj/usr/src/sys/BARTON i386
>Description:
	The genericize.pl script in src/tools/tools/genericize misses
	some comments when invoked with -c option.
>How-To-Repeat:
	Use genericize.pl -c on a GENERIC i386 config
	It misses two lines :
					# output.  Adds ~128k to driver.
	and
					# output.  Adds ~215k to driver.
>Fix:
	Apply this patch :

--- genericize.patch begins here ---
Index: genericize.pl
===================================================================
RCS file: /home/ncvs/src/tools/tools/genericize/genericize.pl,v
retrieving revision 1.2
diff -u -r1.2 genericize.pl
--- genericize.pl	29 Aug 2004 19:45:50 -0000	1.2
+++ genericize.pl	15 Sep 2004 17:50:00 -0000
@@ -66,7 +66,7 @@
     while (<GENERIC>) {
 	my $line = $_;
 	chomp();
-	if ($opts{'c'} && m/^\#/) {
+	if ($opts{'c'} && m/^\s*\#/) {
 	    if ($blank) {
 		print "\n";
 		$blank = 0;
--- genericize.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list