bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
dan at obluda.cz
Sun Sep 12 23:40:50 PDT 2004
The following reply was made to PR bin/71631; it has been noted by GNATS.
From: Dan Lukes <dan at obluda.cz>
To: Giorgos Keramidas <keramida at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
Date: Mon, 13 Sep 2004 08:37:55 +0200
> Setting `int fd = fd' is also an initialiation that is a waste of
Not true as it's optimized-out despite of O level. It's
hack/information for compiler, not real assignment statement.
> I see no reason why it's better than an initialization
> that also buys us some safety.
Agree. Lets initialise fd to -1
More information about the freebsd-bugs