bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
dan at obluda.cz
Sun Sep 12 18:20:24 PDT 2004
The following reply was made to PR bin/71631; it has been noted by GNATS.
From: Dan Lukes <dan at obluda.cz>
To: Giorgos Keramidas <keramida at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
Date: Mon, 13 Sep 2004 03:11:47 +0200 (CEST)
On Sun, 12 Sep 2004, Giorgos Keramidas wrote:
>> - int n, arg, fd, len, verbose, save_errno, hide1, hide1off, hide2;
>> + int n, arg, len, verbose, save_errno, hide1, hide1off, hide2;
>> + int fd = fd; /* init to avoid "might be used unitialized" warning 8/
> fd = -1; would be a better initialization, since no valid descriptor can
> ever be negative and this will expose any bugs that using fd before a
> proper initialization can trigger.
But unnecesarry over-initialisation is waste of resources.
It's about decision ...
I have no opinion which is better (generally).
More information about the freebsd-bugs