bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code

Giorgos Keramidas keramida at freebsd.org
Sun Sep 12 13:10:55 PDT 2004


The following reply was made to PR bin/71616; it has been noted by GNATS.

From: Giorgos Keramidas <keramida at freebsd.org>
To: Dan Lukes <dan at obluda.cz>
Cc: bug-followup at freebsd.org
Subject: Re: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code
Date: Sun, 12 Sep 2004 21:23:45 +0300

 On 2004-09-12 04:37, Dan Lukes <dan at obluda.cz> wrote:
 > *** usr.sbin/yp_mkdb/yp_mkdb.c.ORIG	Sun Sep  5 18:54:07 2004
 > --- usr.sbin/yp_mkdb/yp_mkdb.c	Sun Sep  5 19:01:20 2004
 > [...]
 > - 	snprintf(buf, sizeof(buf), "%lu", time(NULL));
 > + 	snprintf(buf, sizeof(buf), "%lu", (long unsigned int)time(NULL));
 
 Just a minor comment: An (unsigned long) cast should be fine here.
 
 There's no need to add `int' and the ordering of long unsigned seems a bit
 backwards -- most of the time I've seen it written with `unsigned' first.
 
 - Giorgos
 


More information about the freebsd-bugs mailing list