bin/71630: [PATCH] cleanup of the usr.sbin/pppd code

[Giorgos Keramidas]

The following reply was made to PR bin/71630; it has been noted by GNATS.

From: Giorgos Keramidas <keramida at freebsd.org>
To: Dan Lukes <dan at obluda.cz>
Cc: bug-followup at freebsd.org
Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code
Date: Sun, 12 Sep 2004 22:42:06 +0300

 On 2004-09-12 04:38, Dan Lukes <dan at obluda.cz> wrote:
 > -     FILE *iffile;
 > +     FILE *iffile = iffile; /* to avoid "may be used unitialized" warning */
 
 Nope.  NULL is the proper initialization value for (FILE *) objects.
 This way any bugs that might exist further down will be exposed by a
 dereference of a NULL pointer which everyone will notice.  Hiding the
 bugs behind an even more bogus initialization is not a good thing.
 
 The rest of this looks fine, IMHO.