bin/71667: [PATCH] cleanup of the usr.sbin/bootparamd code

Dan Lukes dan at obluda.cz
Sun Sep 12 10:40:27 PDT 2004


>Number:         71667
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/bootparamd code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:26 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan at kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/bootparamd/callbootd/callbootd.c,v 1.10 2003/06/20 04:54:27 jmg
include/rpcsvc/bootparam_prot.x,v 1.7 2003/05/04 02:51:42 obrien

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/bootparamd/callbootd/callbootd.c:83: warning: 'clnt' might be used uninitialized in this function
bootparam_prot_clnt.c:24: warning: implicit declaration of function `memset'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/bootparamd/callbootd/callbootd.c.ORIG	Tue Jul 15 22:47:06 2003
--- usr.sbin/bootparamd/callbootd/callbootd.c	Sun Sep 12 16:24:45 2004
***************
*** 80,86 ****
  
  
    long the_inet_addr;
!   CLIENT *clnt;
    enum clnt_stat clnt_stat;
  
    stat_whoami_res.client_name = cln;
--- 80,86 ----
  
  
    long the_inet_addr;
!   CLIENT *clnt = clnt; /* "init" to avoid "might be used uninitialized" warning */
    enum clnt_stat clnt_stat;
  
    stat_whoami_res.client_name = cln;
*** usr.sbin/bootparamd/../../include/rpcsvc/bootparam_prot.x.ORIG	Thu May 29 19:24:23 2003
--- usr.sbin/bootparamd/../../include/rpcsvc/bootparam_prot.x	Sun Sep 12 16:27:51 2004
***************
*** 39,44 ****
--- 39,45 ----
  
  #ifdef RPC_HDR
  %#include <rpc/types.h>
+ %#include <string.h>
  %#include <sys/time.h>
  %#include <sys/errno.h>
  %#include <sys/param.h>
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list