bin/71625: [PATCH] cleanup of the usr.sbin/rpc.ypupdated code

Dan Lukes dan at obluda.cz
Sat Sep 11 19:40:28 PDT 2004


>Number:         71625
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/rpc.ypupdated code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:27 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan at kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
$FreeBSD: src/usr.sbin/rpc.ypupdated/yp_dbupdate.c,v 1.8 2004/05/24 13:21:24 stefanf

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/rpc.ypupdated/yp_dbupdate.c:134: warning: long unsigned int format, time_t arg (arg 4)

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/rpc.ypupdated/yp_dbupdate.c.ORIG	Fri May 28 19:23:11 2004
--- usr.sbin/rpc.ypupdated/yp_dbupdate.c	Tue Sep  7 21:47:12 2004
***************
*** 131,137 ****
  		return(rval);
  	}
  
! 	snprintf(yplastbuf, sizeof(yplastbuf), "%lu", time(NULL));
  	key.data = yp_last;
  	key.size = strlen(yp_last);
  	data.data = (char *)&yplastbuf;
--- 131,137 ----
  		return(rval);
  	}
  
! 	snprintf(yplastbuf, sizeof(yplastbuf), "%lu", (unsigned long)time(NULL));
  	key.data = yp_last;
  	key.size = strlen(yp_last);
  	data.data = (char *)&yplastbuf;
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list