bin/71614: [PATCH] cleanup of the usr.sbin/ugidfw code

Dan Lukes dan at
Sat Sep 11 19:40:23 PDT 2004

>Number:         71614
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/ugidfw code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:22 GMT 2004
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
System: FreeBSD 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan at i386
$FreeBSD: src/usr.sbin/ugidfw/ugidfw.c,v 1.2 2004/02/25 03:59:56 rwatson
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/ugidfw/ugidfw.c:67: warning: unused variable `value'
usr.sbin/ugidfw/ugidfw.c:69: warning: unused variable `endp'

*** usr.sbin/ugidfw/ugidfw.c.ORIG	Sun Sep  5 18:37:32 2004
--- usr.sbin/ugidfw/ugidfw.c	Sun Sep  5 18:38:10 2004
*** 64,72 ****
  	char errstr[BUFSIZ];
  	struct mac_bsdextended_rule rule;
- 	long value;
  	int error, rulenum;
- 	char *endp;
  	error = bsde_parse_rule(argc, argv, &rule, BUFSIZ, errstr);
  	if (error) {
--- 64,70 ----

More information about the freebsd-bugs mailing list