kern/73129: IPFW misbehaviour in RELENG_5

[Vladimir Ivanov]

The following reply was made to PR kern/73129; it has been noted by GNATS.

From: Vladimir Ivanov <wawa at yandex-team.ru>
To: Maxim Konovalov <maxim at macomnet.ru>
Cc: bug-followup at freebsd.org
Subject: Re: kern/73129: IPFW misbehaviour in RELENG_5
Date: Mon, 25 Oct 2004 21:41:23 +0400

 Maxim Konovalov wrote:
 
 >Haven't checked the code yet but this PR sounds similar to kern/71910.
 >Could you please check the patch in kern/71910 solves your problem?
 >TIA.
 >
 >  
 >
 They've got trouble with locally originated traffic that's why they've 
 removed in_localip(srcip) check.
 I've got problem with intercepting traffic which flows to directly 
 connected subnet (ip_localaddr(dstip) check).
 
 The idea of this strange "if" operator is absolutly unclear for me. The 
 only meaning which I can see: "disable forwarding traffic which are 
 either locally originated or originally has  been directed to connected 
 subnets". I can't understand why.
 That's why I've removed both checks.
 
 But I still suppose there were some reason to write this code.