kern/72933: [patch] promisc mode on vlan interface does not
yar at comp.chem.msu.su
Fri Nov 19 02:10:27 PST 2004
The following reply was made to PR kern/72933; it has been noted by GNATS.
From: Yar Tikhiy <yar at comp.chem.msu.su>
To: freebsd-gnats-submit at FreeBSD.org, blackv at netroad.ru
Subject: Re: kern/72933: [patch] promisc mode on vlan interface does not work correctly
Date: Fri, 19 Nov 2004 13:05:04 +0300
While the fix you proposed looks really reasonable, I cannot see
how it helps in your particular case. If you look at the code,
you'll see that the first conditional there is !BDG_ACTIVE(ifp),
which isn't true in your setting. Any ideas?
By the way, would you mind using context or unified diff format?
Telling "change file bar.c line number X to FOO" isn't a good way
of sending patches since it isn't robust to other changes that may
have happened to the source file in the meantime. Moreover, the
said format gives context to discuss the code in while your way
More information about the freebsd-bugs