misc/73992: periodic security not showing faily firewall diffs

[Giorgos Keramidas]

On 2004-11-16 17:00, Dmitry Morozovsky <marck at rinet.ru> wrote:
>On Tue, 16 Nov 2004, Giorgos Keramidas wrote:
>> Wouldn't a better fix be to change the default filter in check_diff()
>> to make sure the correct pattern is used?  I'm thinking of something
>> like this:
>>
>> : Index: security.functions
>> : ===================================================================
>> : RCS file: /home/ncvs/src/etc/periodic/security/security.functions,v
>> : retrieving revision 1.4
>> : diff -u -u -r1.4 security.functions
>> : --- security.functions   23 Sep 2004 02:00:51 -0000      1.4
>> : +++ security.functions   16 Nov 2004 11:55:03 -0000
>> : @@ -44,6 +44,9 @@
>> :    if [ "$1" = "new_only" ]; then
>> :      shift
>> :      filter="grep '^>'"
>> : +    case $daily_status_security_diff_flags in
>> : +      *-u*|*-c*) filter="grep '^+[^+]'" ;;
>> : +    esac
>> :    else
>> :      filter="cat"
>> :    fi
>
> It will miss changes in context diffs (they are marked by '!'), won't it?

Hmmm, true.  I have to think of this a bit more.