misc/67012: A potential bug detected in /sys/netatm/uni/unisig_subr.c

[Zhenmin]

>Number:         67012
>Category:       misc
>Synopsis:       A potential bug detected in /sys/netatm/uni/unisig_subr.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 21 14:50:21 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Zhenmin
>Release:        5.2.1
>Organization:
OPERA Research Group, UIUC
>Environment:
>Description:
The potential bug is detected by our analysis tool in file 
/sys/netatm/uni/unisig_subr.c:1210

1207                 bcopy(&ie_cgad_absent,
1208                                 &msg->msg_ie_cgad->ie_u.ie_cgad,
1209                                 sizeof(ie_cgad_absent));
1210                 msg->msg_ie_cgsa->ie_ident = UNI_IE_CGSA;
1211                 ATM_ADDR_COPY(&ap->calling.addr,
1212                                 &msg->msg_ie_cgad->ie_cgad_addr);

>How-To-Repeat:
The potential bug is detected by our analysis tool.
>Fix:
--- unisig_subr.c       2003-07-23 09:28:57.000000000 -0500
+++ unisig_subr.c.fixed       2004-05-21 16:27:46.000000000 -0500
@@ -1207,7 +1207,7 @@
                bcopy(&ie_cgad_absent,
                                &msg->msg_ie_cgad->ie_u.ie_cgad,
                                sizeof(ie_cgad_absent));
-               msg->msg_ie_cgsa->ie_ident = UNI_IE_CGSA;
+               msg->msg_ie_cgad->ie_ident = UNI_IE_CGAD;
                ATM_ADDR_COPY(&ap->calling.addr,
                                &msg->msg_ie_cgad->ie_cgad_addr);

>Release-Note:
>Audit-Trail:
>Unformatted: