kern/64001: [patch] ENSONIQ interrupt handler contains if eval with no effect

[Christian S.J.Peron]

>Number:         64001
>Category:       kern
>Synopsis:       [patch] ENSONIQ interrupt handler contains if eval with no effect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 09 10:40:18 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Christian S.J. Peron
>Release:        FreeBSD 4.8-RELEASE-p13 i386
>Organization:
>Environment:
System: FreeBSD movl 4.8-RELEASE-p13 FreeBSD 4.8-RELEASE-p13 #1: Sat Oct 25 16:45:55 UTC 2003 i at movl:/usr/src/sys/compile/STAFF i386


	
>Description:
	Although it is not that big of a deal, there is an if evaluation
	with no effect in the interrupt handler of the ENSONIQ driver.

	The semi-colon terminates the if construct.

	I have commented it out, but you may just want to delete it all together.

	
>How-To-Repeat:
	N/A
	
>Fix:


--- sys/dev/sound/pci/es137x.c.bak	Tue Mar  9 18:27:18 2004
+++ sys/dev/sound/pci/es137x.c	Tue Mar  9 18:29:22 2004
@@ -465,7 +465,7 @@
 	bus_space_write_4(es->st, es->sh, ES1370_REG_SERIAL_CONTROL, es->sctrl);
 
 	if (intsrc & STAT_ADC) chn_intr(es->rch.channel);
-	if (intsrc & STAT_DAC1);
+	/* if (intsrc & STAT_DAC1); */
 	if (intsrc & STAT_DAC2)	chn_intr(es->pch.channel);
 }
>Release-Note:
>Audit-Trail:
>Unformatted: