kern/63171: USB keyboard rollover error [ukbd.c patch]

[Brian Candler]

The following reply was made to PR kern/63171; it has been noted by GNATS.

From: Brian Candler <B.Candler at pobox.com>
To: John Baldwin <john at baldwin.cx>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch]
Date: Mon, 23 Feb 2004 17:21:23 +0000

 On Mon, Feb 23, 2004 at 10:34:08AM -0500, John Baldwin wrote:
 > The pointer fix does not seem correct.  usbd_set_polling() does take a 
 > usbd_device_handle, not an interface pointer, so the existing code is correct 
 > on -current at least.  Note that on 4.x, the poll method in ukbd.c does not 
 > use usbd_device_handle's but does pass the iface pointer in.  This is due to 
 > the usbd code being different in current and stable.
 
 Ah, this is probably because I updated ukbd.c to a newer version in an
 attempt to see if the problem had already been fixed.
 
 Until I changed it, gcc was giving an "incompatible pointer type" warning in
 two places when ukbd.c was compiled.
 
 In my usbdi.c [1.60] I have:
 
 usbd_set_polling(usbd_interface_handle iface, int on)
 
 But I see that the CVS head [1.84] has usbd_device_handle instead. So you're
 quite right, and sorry for the noise.
 
 > I have committed the ukbd rollover fix however.
 
 Thank you!
 
 Brian.